Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use swift-argument-parser #94

Closed
marciniwanicki opened this issue Oct 30, 2021 · 1 comment
Closed

Use swift-argument-parser #94

marciniwanicki opened this issue Oct 30, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@marciniwanicki
Copy link
Contributor

Is your feature request related to a problem? Please describe.
ArgumentParser API from swift-tools-support-core is deprecated and yields warnings when building with Xcode 13.

Describe the solution you'd like
We should switch to the more modern argument parser https://github.com/apple/swift-argument-parser.

@marciniwanicki marciniwanicki added the enhancement New feature or request label Oct 30, 2021
marciniwanicki added a commit that referenced this issue Oct 31, 2021
**Describe your changes**
Updated project dependencies such as xcodeproj, pathkit, and swift-tools-support-core, so the project can be built with Xcode 13.1.

**Testing performed**
- Ensure all CI checks pass
- Check out the project, verify it builts with Xcode 13.1

**Additional context**
- Building with Xcode 13.1 yields multiple warnings `warning: 'ArgumentParser' is deprecated: use swift-argument-parser instead`. It will require a follow-up (#94).
- We will also need to update the CI configuration to build with Xcode 13.1 (#96).

Signed-off-by: Marcin Iwanicki <[email protected]>
ntduyet added a commit to ntduyet/xcdiff that referenced this issue May 10, 2022
Describe your changes
- Update to use ArgumentParser

Testing performed
- All unit tests are passed.
ntduyet added a commit to ntduyet/xcdiff that referenced this issue May 10, 2022
Describe your changes
- Update to use ArgumentParser

Testing performed
- All unit tests are passed.

Signed-off-by: Duyet Nguyen <[email protected]>
marciniwanicki pushed a commit that referenced this issue May 10, 2022
Describe your changes
- Update to use ArgumentParser

Testing performed
- All unit tests are passed.

Signed-off-by: Duyet Nguyen <[email protected]>
ntduyet pushed a commit to ntduyet/xcdiff that referenced this issue May 10, 2022
Issue number of the reported bug or feature request: bloomberg#94

Describe your changes
- Updated the version in the `Makefile` and ran `make update_version` per https://github.com/bloomberg/xcdiff/blob/main/Documentation/Release.md

Testing performed
- Check the version is updated via running `swift run xcdiff --version`
- Verify CI passes

Signed-off-by: Duyet Nguyen <[email protected]>
@kwridan kwridan closed this as completed Jul 4, 2022
@kwridan
Copy link
Contributor

kwridan commented Jul 4, 2022

Was addressed via #105

michaelmcguire pushed a commit to michaelmcguire/xcdiff that referenced this issue Sep 6, 2022
Describe your changes
- Update to use ArgumentParser

Testing performed
- All unit tests are passed.

Signed-off-by: Duyet Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants