Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML side by side (diff) format #102

Merged
merged 2 commits into from
Apr 25, 2022

Commits on Apr 10, 2022

  1. Add HTML side by side (diff) format

    Main feature:
    - Adding a new html format `htmlSideBySide` that displays results in a diff like format
    - This can sometimes be easier to read through, espically when comparing differences in common values
    
    Supporting changes:
    - HTML escpae utility was pulled out to its own extension to allow sharing between both html renderers
    - A small fix was made to the Makefil to enable regenerating tests
    
    TODO:
    
    - [ ] Iterate on styles, are there any better options?
    - [ ] Are there any alternate format names that are more suitable (e.g. `htmlDiff`)?
    
    Test Plan:
    
    - Generate a diff using the new side by side format and examine the results
    
    ```sh
    swift build
    LOCAL_XCDIFF=$(pwd)/.build/debug/xcdiff
    
    cd Fixtures
    $LOCAL_XCDIFF --format htmlSideBySide --verbose > results.html
    
    open results.html
    ```
    
    Signed-off-by: Kassem Wridan <[email protected]>
    kwridan committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    842753f View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Update diff visual style

    - Added grey background color for empty cells
    - Added a different yellow color for value mismatch keys
    - Removed "Value mismatch" label and replaced with a spacer
    
    Signed-off-by: Kassem Wridan <[email protected]>
    kwridan committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    b819269 View commit details
    Browse the repository at this point in the history