Fix target attributes value mismatch #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marciniwanicki
changed the title
marciniwanicki
force-pushed
the
mi/119-system-capabilities-ordering-issue
branch
2 times, most recently
from
1d5bb98
to
e218696
Compare
Codecov ReportBase: 96.69% // Head: 96.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 96.69% 96.71% +0.02%
==========================================
Files 50 50
Lines 2750 2773 +23
==========================================
+ Hits 2659 2682 +23
Misses 91 91
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marciniwanicki
force-pushed
the
mi/119-system-capabilities-ordering-issue
branch
from
e218696
to
9fcc1da
Compare
SystemCapabilities attributes triggered value mismatch when the attributes where listed in different order. Ordered both project and target attributes to ensure the comparison is not affected by the order of the attributes. Test Plan: - Ensure all CI checks pass - Inspect changes in snapshots files - Copy the same project with SystemCapabilities attributes, re-order manually attributes in one of the projects and do the diff, verify xcdiff does not report any differences Signed-off-by: Marcin Iwanicki <[email protected]>
marciniwanicki
force-pushed
the
mi/119-system-capabilities-ordering-issue
branch
from
9fcc1da
to
0585031
Compare
kwridan
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Thanks @marciniwanicki
Tested locally and modified by modifying the attributes and their order 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #119
Describe your changes
SystemCapabilities attributes triggered value mismatch when the attributes where listed in different order.
Ordered both project and target attributes to ensure the comparison is not affected by the order of the attributes.
Testing performed