Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regenerate command snapshots to makefile #73

Merged

Conversation

kwridan
Copy link
Contributor

@kwridan kwridan commented Dec 24, 2020

  • For convenience the command to regenerate command snapshots has been added to the makefile

Test Plan:

  • run make regenerate_command_snapshots

- For convenience the command to regenerate command snapshots has been added to the makefile

Test Plan:

- run `make regenerate_command_snapshots`

Signed-off-by: Kassem Wridan <[email protected]>
@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #73 (8bd7d37) into main (bb8e51d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files          44       44           
  Lines        1679     1679           
=======================================
  Hits         1615     1615           
  Misses         64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8e51d...8bd7d37. Read the comment docs.

Copy link
Contributor

@marciniwanicki marciniwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make regenerate_command_snapshots works as expected 👍

@kwridan kwridan merged commit ae2d79d into bloomberg:main Dec 29, 2020
@kwridan kwridan deleted the feature/add-regenerate-snapshots-make-command branch December 29, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants