Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate QUEUE_GET_METRICS success message #1446

Closed
mertssmnoglu opened this issue Dec 20, 2024 · 1 comment · Fixed by #1451
Closed

Duplicate QUEUE_GET_METRICS success message #1446

mertssmnoglu opened this issue Dec 20, 2024 · 1 comment · Fixed by #1451
Assignees
Labels
Milestone

Comments

@mertssmnoglu
Copy link
Contributor

Describe the bug
Constant QUEUE_GET_METRICS success message is written twice in Server/utils/messages.js

https://github.com/bluewave-labs/checkmate/blob/4a78adfefdacd08df2b8d39df190821e41a55f3b/Server/utils/messages.js#L102-L103

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Server/utils/messages.js'
  2. Scroll to line 102 and 103
  3. See there are multiple keys with the same name

Expected behavior
Storing only one of two values.

Additional context
I discovered this situation with installing eslint and running it in the Server directory. If you are interested in this kind of errors or warnings please let me know, I can create a PR for it.

@ajhollid
Copy link
Collaborator

Describe the bug Constant QUEUE_GET_METRICS success message is written twice in Server/utils/messages.js

https://github.com/bluewave-labs/checkmate/blob/4a78adfefdacd08df2b8d39df190821e41a55f3b/Server/utils/messages.js#L102-L103

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Server/utils/messages.js'
  2. Scroll to line 102 and 103
  3. See there are multiple keys with the same name

Expected behavior Storing only one of two values.

Additional context I discovered this situation with installing eslint and running it in the Server directory. If you are interested in this kind of errors or warnings please let me know, I can create a PR for it.

Absolutely, if you come across these please open up a PR to fix, appreciate the help!

@mertssmnoglu mertssmnoglu linked a pull request Dec 20, 2024 that will close this issue
1 task
@gorkem-bwl gorkem-bwl added this to the 2.0.1 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants