Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create confirmation dialogs for "Clear all stats" and "Remove all monitors" #901

Closed
gorkem-bwl opened this issue Oct 1, 2024 · 4 comments · Fixed by #939
Closed

Create confirmation dialogs for "Clear all stats" and "Remove all monitors" #901

gorkem-bwl opened this issue Oct 1, 2024 · 4 comments · Fixed by #939
Assignees
Labels

Comments

@gorkem-bwl
Copy link
Contributor

We need two confirmation dialogs for "Clear all stats" and "Remove all monitors" buttons. Those buttons can simply say:

  • Do you want to clear all stats? [Cancel] [Yes, clear all stats]
  • Do you want to remove all monitors? [Cancel] [Yes, clear all monitors]
@gorkem-bwl gorkem-bwl added good first issue Good for newcomers frontend labels Oct 1, 2024
@genial-mani
Copy link

I want to work on this could you please assign me?

@ajhollid
Copy link
Collaborator

ajhollid commented Oct 1, 2024

I want to work on this could you please assign me?

Hi @genial-mani ,

Sure the task is assigned to you. Please see our codebase for examples of how we use MUI components in our project.

We'd love to have your contribution 👌

@jennifer-gan
Copy link
Contributor

Screen.Recording.-.Oct.15.2024.mp4

@gorkem-bwl this is the video recording of the 2 dialogs for delete all monitor and remove stats feature

@gorkem-bwl
Copy link
Contributor Author

Thanks @jennifer-gan

One thing that caught my eye is that, when the popup appears, the screen moves to the left a bit (a few pixels). Can we remove that "shakiness"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants