fix/be/revert-notification-refactor

[ajhollid]

This PR reverts a previous change to move empty array validation to the Joi validation.

FE must be refactored to not send an emtpy array first

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the monitorController.js and joi.js files. In monitorController.js, the handling of notifications in the createMonitor and editMonitor functions has been refined to ensure notifications are processed only if they exist. The joi.js file sees a change in the createMonitorBodyValidation schema, allowing the notifications field to be an empty array, while the editMonitorBodyValidation schema retains a minimum length requirement for notifications. Overall, the core functionalities and error handling mechanisms remain unchanged.

Changes

File Path	Change Summary
Server/controllers/monitorController.js	Modified createMonitor and editMonitor functions to improve notification handling by adding conditional checks before processing notifications.
Server/validation/joi.js	Updated createMonitorBodyValidation schema to allow notifications to be an empty array; editMonitorBodyValidation retains the minimum length requirement.

Possibly related PRs

• feat/be/hardware monitor notifications #1037: The changes in this PR involve updates to the validation schemas for monitor creation and editing, specifically regarding the handling of notifications, which directly relates to the modifications made in the createMonitor and editMonitor functions in the main PR.

Suggested reviewers

• jennifer-gan
• marcelluscaio

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.