-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to logo #962
Add link to logo #962
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
<a | ||
href="https://github.com/bluewave-labs/bluewave-uptime" | ||
target="_blank" | ||
rel="noopener noreferrer" | ||
style={{ textDecoration: "none", color: "inherit" }} | ||
> | ||
<Stack direction="row" alignItems="center" gap={theme.spacing(4)}> | ||
<Stack | ||
justifyContent="center" | ||
alignItems="center" | ||
minWidth={theme.spacing(16)} | ||
minHeight={theme.spacing(16)} | ||
pl="1px" | ||
fontSize={18} | ||
color="white" | ||
sx={{ | ||
position: "relative", | ||
backgroundColor: theme.palette.primary.main, | ||
borderRadius: theme.shape.borderRadius, | ||
userSelect: "none", | ||
}} | ||
> | ||
BU | ||
</Stack> | ||
<Typography | ||
component="span" | ||
mt={theme.spacing(2)} | ||
sx={{ opacity: 0.8, fontWeight: 500 }} | ||
> | ||
BlueWave Uptime | ||
</Typography> | ||
</Stack> | ||
<Typography | ||
component="span" | ||
mt={theme.spacing(2)} | ||
sx={{ opacity: 0.8, fontWeight: 500 }} | ||
> | ||
BlueWave Uptime | ||
</Typography> | ||
</Stack> | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Yo, this link's lookin' fresh, but we gotta make sure it's tight, ya feel me?
Aight, so we got this new link to the GitHub repo, and it's pretty dope. But check it, I got a few things we might wanna tweak:
-
That
style
prop is straight fire, but we might wanna consider movin' that styling to a separate CSS class. Keep it clean, you know what I'm sayin'? -
We're using
target="_blank"
, which is cool for openin' in a new tab, but security's important, fam. We should addrel="noopener noreferrer"
to prevent potential security issues. It's like puttin' a lock on your door, you feel me? -
The link text "BlueWave Uptime" is chillin' inside a
Typography
component. That's cool, but we might wanna think about makin' it more obvious it's a link. Maybe add an underline on hover or somethin' to make it pop? -
For accessibility, we could throw in an
aria-label
to describe what the link does. It's like givin' directions to someone who can't see the street signs, you know?
Here's a little remix of the code to show what I mean:
<a
href="https://github.com/bluewave-labs/bluewave-uptime"
target="_blank"
- rel="noopener noreferrer"
+ rel="noopener noreferrer"
+ aria-label="Visit BlueWave Uptime GitHub repository"
- style={{ textDecoration: "none", color: "inherit" }}
+ className="sidebar-brand-link"
>
{/* ... existing content ... */}
</a>
And then in your CSS:
.sidebar-brand-link {
text-decoration: none;
color: inherit;
}
.sidebar-brand-link:hover .brand-text {
text-decoration: underline;
}
What you think? These tweaks could make this link even more fire while keepin' it secure and accessible. It's like addin' some extra sauce to mom's spaghetti, you know what I'm sayin'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening up a well formatted PR! It makes it much easier for us to review 😄
I have a suggestion for how to simplify the code a bit, have a look at my comments in the code review and see what you think.
Okay! Let me change it. |
Gonna make another PR now. |
This PR adds a link to the logo
Once again, so sorry for the mistake earlier.
Let me know if I need to make further changes.