Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to logo #962

Closed
wants to merge 1 commit into from
Closed

Add link to logo #962

wants to merge 1 commit into from

Conversation

khd33j
Copy link

@khd33j khd33j commented Oct 15, 2024

  • This PR adds a link to the logo

    • Added a link to icon (BU) and 'BlueWave Uptime'
    • The link opens up in a new tab as specified here

Once again, so sorry for the mistake earlier.
Let me know if I need to make further changes.

Sorry, something went wrong.

@khd33j khd33j marked this pull request as ready for review October 15, 2024 08:41
Copy link

coderabbitai bot commented Oct 15, 2024

Walkthrough

The pull request modifies the Sidebar component in Client/src/Components/Sidebar/index.jsx. It replaces the static branding text "BlueWave Uptime" with a clickable link that directs users to the project's GitHub repository. This change involves adjustments to the code structure and minor styling updates while maintaining the sidebar's existing functionality, including user authentication state and navigation. The interactive elements of the sidebar, such as the toggle button and menu items, remain unchanged.

Changes

File Change Summary
Client/src/Components/Sidebar/index.jsx Replaced static branding text with a clickable link to the GitHub repository; adjusted code structure and minor styling.

Possibly related PRs

  • Added docs and changelog to main menu #947: This PR modifies the Sidebar component by adding new menu items and enhancing navigation, which may relate to the changes made in the branding section of the sidebar.
  • revamp side-menu #956: This PR restructures the Sidebar component's menu items and navigation logic, which could be relevant to the overall modifications in the sidebar's functionality and layout.

Suggested reviewers

  • jennifer-gan
  • ajhollid

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c2e0037 and 5b31fcc.

📒 Files selected for processing (1)
  • Client/src/Components/Sidebar/index.jsx (1 hunks)
🧰 Additional context used

Comment on lines +176 to +208
<a
href="https://github.com/bluewave-labs/bluewave-uptime"
target="_blank"
rel="noopener noreferrer"
style={{ textDecoration: "none", color: "inherit" }}
>
<Stack direction="row" alignItems="center" gap={theme.spacing(4)}>
<Stack
justifyContent="center"
alignItems="center"
minWidth={theme.spacing(16)}
minHeight={theme.spacing(16)}
pl="1px"
fontSize={18}
color="white"
sx={{
position: "relative",
backgroundColor: theme.palette.primary.main,
borderRadius: theme.shape.borderRadius,
userSelect: "none",
}}
>
BU
</Stack>
<Typography
component="span"
mt={theme.spacing(2)}
sx={{ opacity: 0.8, fontWeight: 500 }}
>
BlueWave Uptime
</Typography>
</Stack>
<Typography
component="span"
mt={theme.spacing(2)}
sx={{ opacity: 0.8, fontWeight: 500 }}
>
BlueWave Uptime
</Typography>
</Stack>
</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Yo, this link's lookin' fresh, but we gotta make sure it's tight, ya feel me?

Aight, so we got this new link to the GitHub repo, and it's pretty dope. But check it, I got a few things we might wanna tweak:

  1. That style prop is straight fire, but we might wanna consider movin' that styling to a separate CSS class. Keep it clean, you know what I'm sayin'?

  2. We're using target="_blank", which is cool for openin' in a new tab, but security's important, fam. We should add rel="noopener noreferrer" to prevent potential security issues. It's like puttin' a lock on your door, you feel me?

  3. The link text "BlueWave Uptime" is chillin' inside a Typography component. That's cool, but we might wanna think about makin' it more obvious it's a link. Maybe add an underline on hover or somethin' to make it pop?

  4. For accessibility, we could throw in an aria-label to describe what the link does. It's like givin' directions to someone who can't see the street signs, you know?

Here's a little remix of the code to show what I mean:

 <a 
   href="https://github.com/bluewave-labs/bluewave-uptime" 
   target="_blank" 
-  rel="noopener noreferrer" 
+  rel="noopener noreferrer"
+  aria-label="Visit BlueWave Uptime GitHub repository"
-  style={{ textDecoration: "none", color: "inherit" }}
+  className="sidebar-brand-link"
 >
   {/* ... existing content ... */}
 </a>

And then in your CSS:

.sidebar-brand-link {
  text-decoration: none;
  color: inherit;
}

.sidebar-brand-link:hover .brand-text {
  text-decoration: underline;
}

What you think? These tweaks could make this link even more fire while keepin' it secure and accessible. It's like addin' some extra sauce to mom's spaghetti, you know what I'm sayin'?

Copy link
Collaborator

@ajhollid ajhollid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening up a well formatted PR! It makes it much easier for us to review 😄

I have a suggestion for how to simplify the code a bit, have a look at my comments in the code review and see what you think.

Client/src/Components/Sidebar/index.jsx Show resolved Hide resolved
@ajhollid
Copy link
Collaborator

  • This PR adds a link to the logo

    • Added a link to icon (BU) and 'BlueWave Uptime'
    • The link opens up in a new tab as specified here

Once again, so sorry for the mistake earlier. Let me know if I need to make further changes.

No problem, thanks for updating your PR 👍

Sorry, something went wrong.

@khd33j
Copy link
Author

khd33j commented Oct 15, 2024

Okay! Let me change it.
Thanks for the feedback!

@khd33j khd33j closed this Oct 15, 2024
@khd33j
Copy link
Author

khd33j commented Oct 15, 2024

Gonna make another PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants