-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screenshots of the themes #70
Comments
I like the idea, especially because sometimes is hard to describe the theme with just a few words. My only concern is that the list would get too big 😰 What do you think @bnb? |
@matheuss Could have the 5 most popular themes in the main readme and add everything else to a separate Markdown file. |
How about a separate Markdown file, where all screenshots of the themes are available and in the main Markdown file a link to this file is created, so you only need to open this file when you want to see the screenshots. |
I like the idea of a separate markdown file, with every awesome-item in README.md with an anchor to the correct theme image in the new file. @sindresorhus Stars would be the only way I can think of to judge "most popular". Do you have other ideas? |
There's going to be hundreds of themes in a year and that will not scale if everything is listed in the main readme. That's why I suggested showing the most popular ones or the prettiest ones (very subjective though) and then more in a separate file.
You want usage popularity, not star popularity. Look at the npm download numbers instead. |
@sindresorhus Sorry, I don't think I communicated effectively - I was agreeing. I was thinking along these lines:
hyperterm-theme - View Theme - Dark - Awesome description Where every theme has a hyperlink ( |
I think I'm the one that didn't communicate effectively ;) I got what you meant, but I don't think it will scale even with just text links, when it grows to hundreds of themes. |
I like the idea of having a "Top 5" or something in the main readme, but I don't think that a separate file is necessary since one of the guidelines is:
Because of that, the |
@sindresorhus Yes, as @matheuss said there is a guideline that there's a visual representation - I always check themes for embedded images and frequently use a Saved Reply when the image doesn't work correctly. Putting a comment at the top of themes might work saying that you can follow the link to see a screenshot might work (in addition to 5 best/most popular/top themes)? |
But then we're back to the user having to follow every single link to view all the themes. To be completely clear, here's what I'm proposing in the main readme.md: ThemesShowing top 5. View all. SnazzyAnotherYet AnotherUnicornRainbowSee all themes |
Ah, okay. That looks and sounds 👍 to me. |
bump? |
@keplersj Feel free to submit a PR! Would be happy to implement this 🤗 I'm just not 100% sure what the best way to do this is - pull the images from the npm repos is probably an easy bet. Additionally, what's our best bet on determining which have the most downloads quickly, and updating when that changes? I don't want to take an instant snapshot of the best right now and then update every so often if there's a better way to do it. |
@bnb If I have some time this weekend I'll give it a shot |
@keplersj Awesome - looking forward to it, if you can! 🙏 |
@sindresorhus How did you show to color scheme at the top like you did in your screenshots? |
is there any hyper-switch plugin to find out which themes works the best way with your code? |
smth like vs code has |
Themes are visual and it's hard to get a feel for them from just a short description, so people would usually end up having to visit them all. Would be nice if the list of themes included a screenshot of each theme. Even better if they were made by scripting HyperTerm programmatically so all screenshots had the same dimensions and content.
For inspiration of how it could look, see https://github.com/sindresorhus/quick-look-plugins
The text was updated successfully, but these errors were encountered: