New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some suggestions #1

Open

s-celles opened this issue Oct 1, 2023 · 0 comments

s-celles commented Oct 1, 2023 •

edited

Loading

Hello,

this code is a very interesting tutorial to Flet but you should:

cleanup code by using black (or something similar)
avoid star import
remove pycache from repository
make a similar app with an ORM such as SQLAlchemy
avoid variable such as "x" https://github.com/bobwatcherx/FletCRUDSchollapp/blame/fcdc5ec28a53e3cf84884ebc6208c32aaad1197f/datatable.py#L113

Hope that helps.

Kind regards

PS : I would also name function such as showedit -> show_edit, ...

s-celles mentioned this issue

Using context manager bobwatcherx/FletSqlAlchemySQlite#1

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment