Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove string-key restriction for OrderedListInterface#toMap #268

Open
boesing opened this issue Oct 22, 2024 · 0 comments
Open

Remove string-key restriction for OrderedListInterface#toMap #268

boesing opened this issue Oct 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@boesing
Copy link
Owner

boesing commented Oct 22, 2024

There is a restriction in OrderedListInterface#toMap as of now so that we can actually prevent from creating another OrderedListInterface hidden in a MapInterface.

The main reason all of this exists is that there are issues with PHP type juggling in array keys and JSON responses:

https://3v4l.org/Y2ld5
https://3v4l.org/eI0Yj

My idea would be to actually remove the limitation of having integer keys but we should still prevent lists. Not quite sure how to do that but thats a problem for future max.

@boesing boesing added the enhancement New feature or request label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant