Add support for text/x-shellscript #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was inspired by how `libmagic` from `file(1)` detects shell scripts, as seen here: https://github.com/file/file/blob/e9bab11f6a4baebfa01e6a754d3f5263c93e8daa/magic/Magdir/varied.script If we introduce support for other text formats which begin with `#!`, e.g. Python or Ruby or Perl scripts with interpreter shebangs, we can always move this matcher lower in the `MATCHER_MAP` priority list.
|
Hello, thanks for the PR! Published in 0.3.2. |
|
Thanks for the quick review and publish! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
text::is_shellscript()matcher, adapted from howlibmagicfromfile(1)detects shell scripts (source).is_shellscript(b"#!")returnsfalse.sample.shfile.Changed
text/x-shellscriptentry toMATCHER_MAP.If we introduce support for other text formats which begin with
#!, e.g. Python or Ruby or Perl scripts containing interpreter shebangs, we can always move this matcher lower in theMATCHER_MAPpriority list.