Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned to 5.22? #8

Open
matthewpersicowork opened this issue Mar 3, 2021 · 2 comments
Open

Pinned to 5.22? #8

matthewpersicowork opened this issue Mar 3, 2021 · 2 comments

Comments

@matthewpersicowork
Copy link

Is there any particular reason you pinned the code to Perl 5.22 in release 1.06? We are using Perl 5.16 and therefore must use version 1.05. I didn't see anything that jumped out at me as being 5.22-specific. Thank you.

@richardjharris
Copy link

I forked the repo and ran the tests under 5.16, and they seem to be fine:

https://travis-ci.com/github/richardjharris/perl-Net-Kafka

@cromedome
Copy link

cromedome commented Sep 8, 2023

It should work on anything back to 5.10 (thanks, Perl::MinimumVersion!):

$ perlver perl-Net-Kafka

   ------------------------------------------------------------------------
 | file                                     | explicit | syntax  | external |
 | ------------------------------------------------------------------------ |
 | perl-Net-Kafka/Makefile.PL               | v5.22.0  | v5.6.0  | n/a      |
 | perl-Net-Kafka/t/01-producer.t           | ~        | v5.6.0  | n/a      |
 | perl-Net-Kafka/t/constants.t             | ~        | v5.6.0  | n/a      |
 | perl-Net-Kafka/t/00-load.t               | ~        | v5.6.0  | n/a      |
 | perl-Net-Kafka/t/02-topic-list.t         | ~        | ~       | n/a      |
 | perl-Net-Kafka/t/03-consumer.t           | ~        | v5.6.0  | n/a      |
 | perl-Net-Kafka/t/lib/TestProducer.pm     | ~        | v5.10.0 | n/a      |
 | perl-Net-Kafka/t/lib/TestConsumer.pm     | ~        | v5.10.0 | n/a      |
 | perl-Net-Kafka/lib/Net/Kafka.pm          | ~        | v5.10.0 | n/a      |
 | perl-Net-Kafka/lib/Net/Kafka/Util.pm     | ~        | v5.6.0  | n/a      |
 | perl-Net-Kafka/lib/Net/Kafka/Producer.pm | ~        | v5.10.0 | n/a      |
 | perl-Net-Kafka/lib/Net/Kafka/Consumer.pm | ~        | v5.10.0 | n/a      |
 | ------------------------------------------------------------------------ |
 | Minimum explicit version : v5.22.0                                       |
 | Minimum syntax version   : v5.10.0                                       |
 | Minimum version of perl  : v5.22.0                                       |
   ------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants