Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #53 introduced a regression into boost pool #64

Open
ni-vzavalishin opened this issue Jan 15, 2025 · 0 comments
Open

PR #53 introduced a regression into boost pool #64

ni-vzavalishin opened this issue Jan 15, 2025 · 0 comments

Comments

@ni-vzavalishin
Copy link

TL;DR: PR #53 seems to be based on a wrong assumption. In fact,simple_segregated_storage in its present form is fundamentally uncapable of handling mixed partition sizes, and cannot be "fixed" to allow that handling without a major change of the implementation. The linked-to Example 4.1, which was a starting point for the "fix", also looks simply wrong and so does the fix itself.

There is a new PR here, which contains further details, including

  • the demonstration of the regression (the 1st commit of the new PR),
  • the reverting of the code change (2nd commit of the new PR) and
  • dropping of the two failing uint tests introduced by PR Fix the Broken malloc_n Behavior #53, which are believed to be incorrect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant