-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducing results from the java implementation #19
Comments
Hi, thank you for issue! The software from Mathet et al. https://gamma.greyc.fr/ is not using the parameters that have been mentionned in the paper. We found the same discrepancy as you when we did the re-implementation. |
Hi, |
Yes a sample of your data might help us to understand how you get this discrepancy indeed!
If i well understood, you obtained the negative gamma value -0.07 with the java version?
What range are you referring to ? |
This is the data I'm currently using: continuum.csv.gz
Exactly. It also gives a range (probably a kind of confidence interval), which is the -0.13 <= gamma <= -0.02 that I reported.
You said that there could be slight differences to the original implementation, that's what I meant by "range". |
Hi, After investigations, your low value of gamma might come that there are many splits of your pred timeline (a segment t1-tn transformed in t1-t2, t2-t3,... t(n-1)-tn) This type error is heavily penalized by the gamma as it is looking for an alignment. As mentioned in this other issue #16 the use of the gamma as a metric remains an open research question we think. |
As update v0.2.0 fixes any problems regarding differences between the java implementation and ours', and those differences are explained in the new "Issues" section of the documentation, this issue is outdated. |
Thanks for the package!
Problem
I'm currently trying to switch from the "official" implementation (https://gamma.greyc.fr/) to this one, but I'm having trouble getting to the same results.
Reproducing
As an example, I tried the Alex, Paul, Suzan data from the java web app. Converted to the format the continuum expects, it looks as follows:
In the web app, this gives me γ = 0.451034437799.
Using the same data in your implementation gives a different value for gamma:
I've also tried my own data, where the results sometimes differ even more (negative vs. positive).
I'm using alpha=1 and beta=1, which, as I understand from the Gamma paper, seem to be the default values. However, I'm not sure whether these are the values used in the java implementation and haven't managed to find out.
Is there any parameter I'm missing or setting to a wrong value?
I'm using pygamma_agreement==0.1.6 with python 3.8.7 on Fedora 33.
PS: Curiously, I just noticed that I'm also getting different results from the java web app and the java offline app, which gives me gamma=0.55
The text was updated successfully, but these errors were encountered: