Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borg2: check [--repair] improvements #8466

Open
ThomasWaldmann opened this issue Oct 8, 2024 · 1 comment
Open

borg2: check [--repair] improvements #8466

ThomasWaldmann opened this issue Oct 8, 2024 · 1 comment

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Oct 8, 2024

Currently (beta12), borg2 check just deletes the chunks index cached in the repo. This is because borg check --repair might have deleted some invalid repo objects, thus the cached chunks index is not uptodate anymore. After that, first access to the repo will rebuild the chunks index cache (slow).

Guess we could just build and cache a new chunks index within borg check --repair and maybe also in borg check without --repair.

@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Oct 10, 2024

Some improvements were done in #8468:

It builds a ChunkIndex in the repository part of the check (for close to zero addtl. cost) and reuses it in the archives part (saving the slow rebuild there we had before).

After the archives part, it still kills the ChunkIndex and triggers another rebuild by next operation though.

@ThomasWaldmann ThomasWaldmann modified the milestones: 2.0.0b13, 2.0.0b14 Oct 26, 2024
@ThomasWaldmann ThomasWaldmann modified the milestones: 2.0.0b14, 2.0.0b15 Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant