New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Was this merged back into facebook/create-react-app? #2

Open

cwellsx opened this issue Jun 7, 2020 · 1 comment

cwellsx commented Jun 7, 2020

I'm reading facebook#1333
and therefore I found https://github.com/facebook/create-react-app/pull/3741/commits
which says that the changes in this repo were pulled into facebook:next.

What is facebook:next (I don't see it anywhere)?

Were your changes ever merged into a release branch of the facebook repo (for example facebook@bf2d814 which include your changes to paths.js)?

I don't see your changes in the current master branch of the facebook repo.

If they're not included, do you know why not (where/when/why was the decision made not to include them)?

The text was updated successfully, but these errors were encountered:

Author

cwellsx commented Jun 8, 2020 •

edited

Loading

I see the change was reverted here -- facebook@50b4857

And the explanation for that change seems to be here -- facebook#5024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment