Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(44) Use sync.Pool instead? link #334

Open
Tracked by #238
ibihim opened this issue Nov 29, 2024 · 1 comment
Open
Tracked by #238

(44) Use sync.Pool instead? link #334

ibihim opened this issue Nov 29, 2024 · 1 comment
Assignees
@kramaranya
Labels
sig-auth-acceptance issues created during review for sig-auth-acceptance

Comments

@ibihim
Copy link
Collaborator

ibihim commented Nov 29, 2024 •
edited
Loading

What

Consider using sync.Pool in templateWithValue.

Why

Because this is being executed by go routines (requests) and sync.Pool might be a good solution for that.

Reference

https://github.com/brancz/kube-rbac-proxy/pull/229/files#diff-c5321b4f3131d9d6f28032421cf6e9bb16827f1f887c808a380d6a0eb1bf5488R188
@ibihim ibihim mentioned this issue Nov 29, 2024
Open
58 tasks
@ibihim ibihim added the sig-auth-acceptance issues created during review for sig-auth-acceptance label Nov 29, 2024
@kramaranya
Copy link
Contributor

I would like to take this issue @ibihim

@kramaranya kramaranya mentioned this issue Jan 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kramaranya kramaranya

Labels
sig-auth-acceptance issues created during review for sig-auth-acceptance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibihim @kramaranya