Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(51) Return interface instead of unexported struct link. #335

Open
Tracked by #238
ibihim opened this issue Nov 29, 2024 · 1 comment
Open
Tracked by #238

(51) Return interface instead of unexported struct link. #335

ibihim opened this issue Nov 29, 2024 · 1 comment
Assignees
@ShazaAldawamneh
Labels
good first issue sig-auth-acceptance issues created during review for sig-auth-acceptance

Comments

@ibihim
Copy link
Collaborator

ibihim commented Nov 29, 2024 •
edited
Loading

What

Export the StaticAuthorizer.

Why

It is preferred to take interfaces as input and return types as output, but the staticAuthorizer isn't getting exported, which makes the usage unpleasant.

Reference

https://github.com/brancz/kube-rbac-proxy/pull/229/files#diff-90ae54b34ce395dcd2c182ea13a18a4979c09ae5dbbda98a1b24aa8abaa0f8b5L50
@ibihim ibihim mentioned this issue Nov 29, 2024
Open
58 tasks
@ibihim ibihim added good first issue sig-auth-acceptance issues created during review for sig-auth-acceptance labels Nov 29, 2024
@ShazaAldawamneh
Copy link

I can take this issue . @ibihim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShazaAldawamneh ShazaAldawamneh

Labels
good first issue sig-auth-acceptance issues created during review for sig-auth-acceptance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibihim @ShazaAldawamneh