Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(28) Force a manual opt-in for legacy SA token? link #336

Open
Tracked by #238
ibihim opened this issue Nov 29, 2024 · 0 comments
Open
Tracked by #238

(28) Force a manual opt-in for legacy SA token? link #336

ibihim opened this issue Nov 29, 2024 · 0 comments
Labels
sig-auth-acceptance issues created during review for sig-auth-acceptance

Comments

@ibihim
Copy link
Collaborator

ibihim commented Nov 29, 2024

What

  • (1) Don't accept legacy token, except a flag is being used that enables legacy tokens.
  • (2) Reject tokens that don't address us (kube-apiserver SA tokens).

Why

  • (1) Legacy tokens are more insecure and are being phased out.
  • (2) It is hard to predict what kind of audience "upstream" is, but we can be sure it is not kube-apiserver.

Reference

https://github.com/brancz/kube-rbac-proxy/pull/229/files#diff-5379bac64778825441ad4a223c319e73645905b9864419d08eb7b8d2db974cddR141-R143

@ibihim ibihim added the sig-auth-acceptance issues created during review for sig-auth-acceptance label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig-auth-acceptance issues created during review for sig-auth-acceptance
Projects
None yet
Development

No branches or pull requests

1 participant