Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add non-verified Creators to Auto-Contribute list and remove related toggle #29393

Closed
2 tasks
Miyayes opened this issue Mar 29, 2023 · 2 comments · Fixed by brave/brave-core#18364
Closed
2 tasks
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 29, 2023

Description

  • Only add sites / channels to A-C list if Verified Creator
  • Remove the toggle screenshotted below

image

cc: @LaurenWags Based on some discussion on Tip Banner 3.0 Demo call.

@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 29, 2023
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 29, 2023
@Miyayes Miyayes added the QA/Yes label Apr 18, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 5, 2023
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 5, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 5, 2023

Verification PASSED on

Brave | 1.53.76 Chromium: 114.0.5735.90 (Official Build) beta (64-bit)
-- | --
Revision | 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS | Windows 10 Version 22H2 (Build 19045.2965)

New user

  • Confirmed that the settings Show non-verified sites in the list is removed from the AC advanced settings page
  • Confirmed that the non-verified creators are not added to the AC table
  • Confirmed that verified pubs are listed in the AC table
  • Confirmed that the sum of Attention for the verified creators is 100 %
  • Confirmed that verified site can be removed and re-added to the AC table
Example Example
image image (1)

Existing user

  • Install 1.52.107
  • Enable rewards and connect custodian
  • Add verified and non-verified pubs to AC table
  • Upgrade the profile to 1.53.x
1.52.107 1.52.107
image image
1.53.76 1.53.76
image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 6, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 12, 2023

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.53.83

New user

  • Confirmed that the settings Show non-verified sites in the list is removed from the AC advanced settings page
  • Confirmed that the non-verified creators are not added to the AC table
  • Confirmed that verified pubs are listed in the AC table
  • Confirmed that the sum of Attention for the verified creators is 100 %
  • Confirmed that verified site can be removed and re-added to the AC table
Example Example
Screenshot_20230612_153312 Screenshot_20230612_153319

Existing user

  • Install 1.52.107
  • Enable rewards and connect custodian
  • Add verified and non-verified pubs to AC table
  • Upgrade the profile to 1.53.x
1.52.107 1.52.107
Screenshot_20230612_154600 Screenshot_20230612_154610
1.53.x 1.53.x
Screenshot_20230612_154707 Screenshot_20230612_154715

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants