Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Unify iOS kShouldAlwaysRunBraveAdsServiceFeature #35520

Closed
Tracked by #33470
tmancey opened this issue Jan 23, 2024 · 1 comment · Fixed by brave/brave-core#21736 or brave/brave-core#22008
Closed
Tracked by #33470

[ads] Unify iOS kShouldAlwaysRunBraveAdsServiceFeature #35520

tmancey opened this issue Jan 23, 2024 · 1 comment · Fixed by brave/brave-core#21736 or brave/brave-core#22008
Assignees
@aseren
Labels
enhancement feature/ads OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.64.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jan 23, 2024 •
edited by aseren
Loading

Added ability to start Brave Ads service if ShouldAlwaysRunBraveAdsService feature is true when Brave Rewards is disabled. ShouldAlwaysRunBraveAdsService feature is disabled by default.
@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/iOS Fixes related to iOS browser functionality labels Jan 23, 2024
@tmancey tmancey mentioned this issue Jan 23, 2024
Closed
3 tasks
@tmancey tmancey mentioned this issue Jan 23, 2024
Closed
3 tasks
This was referenced Jan 24, 2024
Merged
Open
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Jan 26, 2024
@brave-builds brave-builds mentioned this issue Jan 26, 2024
Closed
7 tasks
@aseren aseren mentioned this issue Feb 12, 2024
Merged
24 tasks
@aseren aseren reopened this Feb 12, 2024
@kjozwiak kjozwiak mentioned this issue Mar 20, 2024
Closed
25 tasks
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 21, 2024
@hffvld
Copy link
Contributor

hffvld commented Mar 21, 2024 •
edited
Loading

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4
Brave build: 1.64 (72)
BraveCore: 1.64.72 (122.0.6261.29)

ShouldAlwaysRunBraveAdsService feature DISABLED

Test case 1

STEPS:

  1. Fresh install Brave
  2. Launch Brave > Verify Ads service is not started

ACTUAL RESULTS:

  • Verified that Ads service is not started
1 2 3
1 2 3
Test case 2

STEPS:

  1. Fresh install Brave
  2. Launch Brave
  3. Join Brave Rewards > Verify Ads service is started
  4. Quit Brave
  5. Relaunch Brave > Verify Ads service is started
  6. Disable Brave Rewards > Verify Ads service is stopped
  7. Quit Brave
  8. Relaunch Brave > Verify Ads service is not started

ACTUAL RESULTS:

  • Verified that the Ads service is started when Rewards is enabled
  • Verified that the Ads service is stopped/not started when Rewards is disabled
Enable Rewards Ads service is started Quit and relaunch Brave
1 2 3
Disable Rewards Ads service is stopped Quit and relaunch Brave
1 2 3
Test case 3

STEPS:

  1. Fresh install Brave
  2. Launch Brave
  3. Join Brave News > Verify Ads service is started
  4. Quit Brave
  5. Relaunch Brave > Verify Ads service is started
  6. Disable Brave News > Verify Ads service is stopped
  7. Quit Brave
  8. Relaunch Brave > Verify Ads service is not started

ACTUAL RESULTS:

  • Verified that the Ads service is started when News is enabled
  • Verified that the Ads service is stopped/not started when News is disabled
Enable News Ads service is started Quit and relaunch Brave
1 2 3
Disable News Ads service is stopped Quit and relaunch Brave
1 2 3

ShouldAlwaysRunBraveAdsService feature ENABLED

Test case 1

STEPS:

  1. Fresh install Brave
  2. Launch Brave > Verify Ads service is started
  3. Quit Brave
  4. Relaunch Brave > Verify Ads service is started

ACTUAL RESULTS:

  • Verified that Ads service is started
1 2 3
1 2 3
Test case 2

STEPS:

  1. Fresh install Brave
  2. Launch Brave > Verify Ads service is started
  3. Join Brave Rewards > Verify Ads service should not be restarted
  4. Quit Brave
  5. Relaunch Brave > Verify Ads service is started
  6. Disable Brave Rewards > Verify Ads service should not stop
  7. Quit Brave
  8. Relaunch Brave > Verify Ads service is started

ACTUAL RESULTS:

  • Verified that the Ads service is started when Brave is launched
  • Verified that the Ads service is not restarted when joining Rewards
  • Verified that the Ads service is not stopped when Rewards is disabled
Ads service is started when launch Brave Join Rewards Ads service is not restarted 1
1 2 3
Ads service is not restarted 2 Ads service is not restarted 3 Ads service is not restarted 4
1 2 3
Quit and relaunch Brave Disable Rewards Ads service is not stopped when the Rewards is disabled > Quit > Relaunch Brave
1 2 3
Test case 3

STEPS:

  1. Fresh install Brave
  2. Launch Brave > Verify Ads service is started
  3. Join Brave News > Verify Ads service should not be restarted
  4. Quit Brave
  5. Relaunch Brave > Verify Ads service is started
  6. Disable Brave News > Verify Ads service should not stop
  7. Quit Brave
  8. Relaunch Brave > Verify Ads service is started

ACTUAL RESULTS:

  • Verified that the Ads service is started when News is enabled
  • Verified that the Ads service is stopped/not started when News is disabled
Ads service is started when launch Brave Enable News Ads service is not restarted
1 2 3
Quit and relaunch Brave Disable News Ads service is not stopped when the News is disabled > Quit > Relaunch Brave
1 2 3

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 21, 2024
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
enhancement feature/ads OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone QA/Yes release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.64.x - Release
4 participants
@tmancey @brave-builds @aseren @hffvld