Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear private data on startup if clearing on shutdown #3673

Open
tildelowengrimm opened this issue Mar 11, 2019 · 2 comments
Open

Clear private data on startup if clearing on shutdown #3673

tildelowengrimm opened this issue Mar 11, 2019 · 2 comments
Labels
priority/P4 Planned work. We expect to get to it "soon". privacy

Comments

@tildelowengrimm
Copy link
Contributor

Our feature to clear private data when Brave is quit doesn't work if Brave is killed unexpectedly, like is someone holds down their power button to force their machine to shut down. There isn't much we can do in these cases, beyond the very elaborate work in #3549. But we can delete that state whenever Brave is opened. That won't prevent a forensic analysis, but it will ensure that leftover state never shows up in the newly-opened browser.

@tildelowengrimm tildelowengrimm added privacy priority/P4 Planned work. We expect to get to it "soon". labels Mar 11, 2019
@DTV96Calibre
Copy link

Sounds like that data should never end up on disk if possible. Maybe an option to store private data in-memory? I'm not aware of the amount of data we're tracking here

@tildelowengrimm
Copy link
Contributor Author

@DTV96Calibre We have a separate issue for the much more substantial task of keeping all browsing data secured with an in-memory-only key when clear-on-shutdown is enabled. #3549 That's going to be a pretty hefty piece of work with a lot of edge cases and testing needed. This is a much more straightforward easier improvement in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P4 Planned work. We expect to get to it "soon". privacy
Projects
None yet
Development

No branches or pull requests

2 participants