Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception rules in custom filters don't work. #5240

Closed
scorpion1201 opened this issue Jul 14, 2019 · 8 comments
Closed

Exception rules in custom filters don't work. #5240

scorpion1201 opened this issue Jul 14, 2019 · 8 comments
Labels
closed/duplicate Issue has already been reported feature/shields/adblock Blocking ads & trackers with Shields

Comments

@scorpion1201
Copy link

Description

Exception rules in custom filters don't work.

Steps to Reproduce

  1. Install Brave Browser.
  2. Add a exception rules in a custom filter box on brave://adblock
  3. Visit the site for which the custom filter was added, be still blocked!

Actual result:

Exception rules in custom filters don't work.

Expected result:

Exception rules work well.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    N/A
  • Can you reproduce this issue with the dev channel?
    N/A
  • Can you reproduce this issue with the nightly channel?
    N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Does the issue resolve itself when disabling Brave Rewards?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Miscellaneous Information:

@bsclifton
Copy link
Member

@scorpion1201 do you have an example of the rule you tried?

cc: @ryanbr

@bsclifton bsclifton added the feature/shields/adblock Blocking ads & trackers with Shields label Jul 15, 2019
@scorpion1201
Copy link
Author

@bsclifton

Yes, the exception rule to blocked filters on 'tv.kakao.com' is below.
@@||t1.daumcdn.net/tiara/js/v1/tiara.min.js

It's not working!

@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Jul 26, 2019
@ggirard07
Copy link

Same issue here with an exception rule...
But as this is my first custom filter, I am not sure if this is actually an issue or a bad usage from myself...

@ggirard07
Copy link

Wondering if this issue could be linked in any way to brave/adblock-lists#45

@bsclifton
Copy link
Member

cc: @ryanbr @pes10k

@pes10k
Copy link
Contributor

pes10k commented Jul 20, 2020

thank you for the issue. Closing in favor of #5440, which covers the same issue

@pes10k pes10k closed this as completed Jul 20, 2020
@pes10k pes10k added closed/duplicate Issue has already been reported and removed priority/P4 Planned work. We expect to get to it "soon". labels Jul 24, 2020
@efolio
Copy link

efolio commented Nov 5, 2020

Any news on this… I still have the issue…

@pes10k
Copy link
Contributor

pes10k commented Nov 6, 2020

@efolio the live version of this issue is #5440, but as good news, its coming up next in our queue, so we hope to have an answer soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/shields/adblock Blocking ads & trackers with Shields
Projects
None yet
Development

No branches or pull requests

6 participants