Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C77 - torrent links do not work in 0.68.133 #5979

Closed
LaurenWags opened this issue Sep 10, 2019 · 5 comments
Closed

C77 - torrent links do not work in 0.68.133 #5979

LaurenWags opened this issue Sep 10, 2019 · 5 comments

Comments

@LaurenWags
Copy link
Member

Description

Torrent links do not work in 0.68.133 (Chromium 77) but they do work in 0.68.132 (Chromium 76). Note, magnet links still work.

@GeetaSarvadnya reproduced and found that torrent links work on Nightly 0.72.11 with Chromium 77, but Nightly has a different webtorrent version.

Steps to Reproduce

  1. Using 0.68.133 navigate to webtorrent.io/free-torrents
  2. Click on a torrent link.

Actual result:

Screen Shot 2019-09-10 at 3 25 57 PM

Expected result:

(this is from Nightly)
Screen Shot 2019-09-10 at 3 59 29 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.68.133 Chromium: 77.0.3865.65 (Official Build) (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 0.68.132 no, 0.68.133 yes
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? no for 0.71.72 Chromium: 76.0.3809.132 (Official Build) dev (note, chromium 76 on dev)
  • Can you reproduce this issue with the nightly channel? no for 0.72.11 Chromium: 77.0.3865.65 (Official Build) nightly (note chromium 77 for nightly)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @rebron @bsclifton

@GeetaSarvadnya noted that Nightly has webtorrent version 1.1.0 where as release channel has 1.0.0

@yrliou
Copy link
Member

yrliou commented Sep 10, 2019

brave/brave-core@70b5ff2
Network service uplift PR in 0.69.x and 0.68.x missed the above commit.
I cherry-pick the missing commit into c77_0.68.x, will open an uplift PR to fix it in 0.69.x too.

@yrliou
Copy link
Member

yrliou commented Sep 10, 2019

0.69.x is soon going to be replaced by current 0.70.x so I guess it's fine to skip the uplift PR.

@btlechowski
Copy link

Reproduced on Ubuntu

Brave 0.68.133 Chromium: 77.0.3865.65 (Official Build) (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Ubuntu 18.04 LTS

@yrliou
Copy link
Member

yrliou commented Sep 10, 2019

Confirmed it works after cherry-pick the missing commit into C77 0.68.x WIP branch.
cherry-pick commit: brave/brave-core@55c6f6c

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 11, 2019

Verification passed on

Brave 0.68.134 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR from the description

image

Verified passed with

Brave 0.68.134 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description
    Screen Shot 2019-09-11 at 8 56 19 AM
    Screen Shot 2019-09-11 at 8 56 25 AM

Verification passed on

Brave 0.68.134 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS
  • Verified STR from description

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants