Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dashboard Settings tool tip for each stats #6084

Open
GeetaSarvadnya opened this issue Sep 19, 2019 · 6 comments
Open

Remove Dashboard Settings tool tip for each stats #6084

GeetaSarvadnya opened this issue Sep 19, 2019 · 6 comments
Labels

Comments

@GeetaSarvadnya
Copy link

Description

Remove Dashboard Settings tool tip for each stats

Steps to Reproduce

  1. Open brave 0.70.97
  2. Open NTP click on the Dashboard settings icon
  3. Mouseover each stats in the dashboard setting popup
  4. Dashboard Settings tooltip is shown for each stats

Actual result:

Mouseover on each stats shows Dashboard Settings tooltip

image (1)

image

Expected result:

Remove Dashboard Settings tooltip for each stats

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa @karenkliu

@btlechowski
Copy link

Still reproducible

Brave 1.13.82 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

image

@otomist
Copy link

otomist commented Jul 25, 2022

I'm going to get started on this. Just to be sure we want this totally removed? Or should the tooltip say something different? @rebron

@ForkInSpace
Copy link

@GeetaSarvadnya if this is still relevant, I'm happy to create a PR for this one.

@ryanstutes
Copy link

ryanstutes commented Mar 6, 2023

@GeetaSarvadnya I think the desired behavior should be as follows:

  • "Customize Dashboard" tooltip shows on title
  • "Close" tooltip shows on X button

I'm going to open a PR for these. If we don't want both of them, happy to revert the 2nd half.

@AlejandroBlanco2001
Copy link

AlejandroBlanco2001 commented Feb 19, 2024

Hey @GeetaSarvadnya @btlechowski , I was seeing that the issue had a PR but it was closed, and I would like to know if it is still relevant and I can take it?

My only question is, only the tooltip should be removed only from the options, in the rest of the modal it should remain right?

@Sriramkashyapks
Copy link

please assign this issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants