Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser crypto wallet still gets detected as Metamask on websites #6135

Closed
srirambv opened this issue Sep 23, 2019 · 1 comment
Closed

Browser crypto wallet still gets detected as Metamask on websites #6135

srirambv opened this issue Sep 23, 2019 · 1 comment

Comments

@srirambv
Copy link
Contributor

Description

Browser crypto wallet still gets detected as Metamask on websites

Steps to Reproduce

  1. Enable crypto wallet on browser
  2. Visit https://cryptokitties.co/
  3. Site detects wallet as Metamask

Actual result:

image
image
Also has Metamask icon in the connect popup window
Learn more links to https://medium.com/metamask/introducing-privacy-mode-42549d4870fa
Once signed in Shows Connected wallet: Metamask
image

Expected result:

No Metamask branding anywhere and sites shouldnt detect it as Metamask

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (32-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @ryanml @bbondy @tomlowenthal

@ryanml ryanml self-assigned this Sep 23, 2019
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 2, 2019
@bbondy
Copy link
Member

bbondy commented Nov 18, 2019

At least for now I don't think we're going to add an isBrave type of function. Websites should not assume and they should feature detect instead of using something like a user agent.

@bbondy bbondy closed this as completed Nov 18, 2019
@bbondy bbondy added closed/wontfix and removed QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. release-notes/exclude labels Nov 18, 2019
@srirambv srirambv removed the bug label Jan 10, 2020
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants