Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binance Deposit address should show Address AND Memo if applicable #9566

Closed
uniibu opened this issue May 1, 2020 · 2 comments
Closed

Binance Deposit address should show Address AND Memo if applicable #9566

uniibu opened this issue May 1, 2020 · 2 comments
Labels
closed/duplicate Issue has already been reported feature/widgets

Comments

@uniibu
Copy link

uniibu commented May 1, 2020

Description

Cryptocurrencies such as EOS, XLM, and XRP needs to have their Address AND Memo shown together.

Steps to Reproduce

  1. Sign in to Binance Widget
  2. Toggle the visibility of the balances and go to Deposit tab
  3. Choose either EOS, XLM, or XRP

Actual result:

On Desktop Release, Binance widget deposit addresses for networks such as EOS, XLM, XRP are only showing the Address
release

An attempt to fix this landed on Beta and Nightly channels brave/brave-core#5267, however, this time it only shows the Memo.
beta-nightly

Expected result:

It should show both Address and Memo and imho, the fix should at least land on the Release channel, because right now, users with little to no knowledge about this currencies might deposit to the given address without the memo, only to find out later that they will not receive it on their Binance accounts.

Reproduces how often:

Brave version (brave://version info)

  • Release
Brave 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
  • Beta
Brave 1.9.50 Chromium: 81.0.4044.129 (Official Build) beta (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
  • Nightly
Brave 1.10.22 Chromium: 81.0.4044.129 (Official Build) nightly (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}

Version/Channel Information:

  • Can you reproduce this issue with the current release? YES
  • Can you reproduce this issue with the beta channel? YES
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? YES

Other Additional Information:

Miscellaneous Information:

@srirambv
Copy link
Contributor

srirambv commented May 1, 2020

Dupe of #9535

@srirambv srirambv closed this as completed May 1, 2020
@srirambv srirambv added the closed/duplicate Issue has already been reported label May 1, 2020
@uniibu
Copy link
Author

uniibu commented May 1, 2020

@srirambv pardon me if i'm wrong,I just wanted to clarify on how could this be a duplicate of a closed issue which is not solved? The supposed fix brave/brave-core#5267 for issues #9535 and #9250 should have landed already at https://github.com/brave/brave-core/tree/v1.10.22

I am now at Nightly 1.10.23

Brave 1.10.23 Chromium: 81.0.4044.129 (Official Build) nightly (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}

And I still get the image below.. No EOS address, just a memo

nightly

I apologize if I'm wrong and just got confused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/widgets
Projects
None yet
Development

No branches or pull requests

3 participants