From 848aca2e51dff47897580f141522482083a0b239 Mon Sep 17 00:00:00 2001 From: mkarolin Date: Fri, 3 Jan 2025 13:44:38 -0500 Subject: [PATCH] [cr133][Rust] unused imports. error: unused import: `Hashable` --> ../../brave/components/brave_wallet/browser/zcash/rust/librustzcash/src/zcash_primitives/src\merkle_tree.rs:7:14 | 7 | Address, Hashable, Level, MerklePath, Position, | ^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]` error: unused import: `Write` --> ../../brave/components/brave_wallet/browser/zcash/rust/librustzcash/src/zcash_primitives/src\transaction\mod.rs:4:27 | 4 | use std::io::{self, Read, Write}; | ^^^^^ Chromium change: https://chromium.googlesource.com/chromium/src/+/6f81efe9a3d000dcbc952d6f14284c8178a960ec commit 6f81efe9a3d000dcbc952d6f14284c8178a960ec Author: Lukasz Anforowicz Date: Thu Jan 2 13:45:03 2025 -0800 Stop globally disabling `unused-imports` lint when compiling Rust. rust-lang/rust#121708 (comment) points out that new linting scenarios have been moved into a separate lint. Thanks to this, we no longer need to globally disable this lint in Chromium (some narrower exclusions still need to apply). Bug: chromium:326247202 --- .../brave_wallet/browser/zcash/rust/librustzcash/BUILD.gn | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/components/brave_wallet/browser/zcash/rust/librustzcash/BUILD.gn b/components/brave_wallet/browser/zcash/rust/librustzcash/BUILD.gn index 1941eae34851..3e3eadd5bd55 100644 --- a/components/brave_wallet/browser/zcash/rust/librustzcash/BUILD.gn +++ b/components/brave_wallet/browser/zcash/rust/librustzcash/BUILD.gn @@ -56,6 +56,10 @@ rust_static_library("zcash_primitives") { "src/zcash_primitives/src/transaction/components/orchard.rs", "src/zcash_primitives/src/transaction/mod.rs", ] + + # TODO(cypt4): Fix unused imports and remove this flag. + + rustflags = [ "-Aunused-imports" ] deps = [ ":zcash_encoding", ":zcash_protocol",