Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Spell check clear all button is too close to pull down button #11741

Closed
luixxiul opened this issue Nov 1, 2017 · 3 comments
Closed

Spell check clear all button is too close to pull down button #11741

luixxiul opened this issue Nov 1, 2017 · 3 comments
Labels
0.19.x issue first seen in 0.19.x addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/about-pages feature/spell-check settings usability wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Nov 1, 2017

Description

Spell check clear all button is too close to pull down button.

clipboard01

Steps to Reproduce

  1. Open about:preferences#general
  2. Click around the spell check pull down button

Actual result:

Sometimes the clear all button is pressed

Expected result:

The clear confirmation message should be displayed if the button cannot be moved next to the languages

Reproduces how often: [What percentage of the time does it reproduce?]

Consistently

Brave Version

about:brave info:

0.19.71

Reproducible on current live release:

No.

Additional Information

#11710

@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 1, 2017

The tab close button styling could be applied here.

@luixxiul luixxiul added the 0.19.x issue first seen in 0.19.x label Nov 1, 2017
@luixxiul
Copy link
Contributor Author

Maybe we do not need that clear all button at all, as probably there are usually only a couple pf languages selected. It should be a rare case that many languages like 10 or more are selected.

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 9, 2018
@bsclifton bsclifton added the addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. label Aug 9, 2018
@bsclifton
Copy link
Member

Closing as wontfix - created issue in brave-core to ensure we have parity for this functionality:
brave/brave-browser#726

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.19.x issue first seen in 0.19.x addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/about-pages feature/spell-check settings usability wontfix
Projects
None yet
Development

No branches or pull requests

3 participants