Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Specifying a position with add_new_at: :top fails to insert at that position #220

Merged
merged 3 commits into from
Aug 23, 2016
Merged

Bug: Specifying a position with add_new_at: :top fails to insert at that position #220

merged 3 commits into from
Aug 23, 2016

Commits on Aug 14, 2016

  1. Bug: Test written to confirm bug

    @brendon
    brendon committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    7d4d220 View commit details
    Browse the repository at this point in the history

  2. Make add_to_list_top behave the same as _bottom 

    I’ve changed the tests to cope with this change in behaviour. This will
potentially be a breaking change for people, though why someone would
be taking advantage of the ‘feature’ whereby specifying a `position` on
`add_new_at: :top` is ignored, is beyond me :)
    @brendon
    brendon committed Aug 14, 2016
    Configuration menu
    Copy the full SHA
    760361d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2016

  1. Merge branch 'master' into add_new_at_top_bug

    @brendon
    brendon committed Aug 22, 2016
    Configuration menu
    Copy the full SHA
    c2c0228 View commit details
    Browse the repository at this point in the history