New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated advice for MySQL DataSource configuration #2250

Open

jdcaperon opened this issue Oct 1, 2024 · 0 comments

jdcaperon commented Oct 1, 2024 •

edited

Loading

Would it be possible to clarify whether the following statement is still true?

https://github.com/brettwooldridge/HikariCP/blob/dev/README.md?plain=1#L470

LoginTimeout still does nothing -> True: https://github.com/spullara/mysql-connector-java/blob/master/src/main/java/com/mysql/jdbc/jdbc2/optional/MysqlDataSource.java#L177-L187

However setNetworkTimeout looks implemented here, which was what was referenced in the previous issue on this topic: #935

https://github.com/mysql/mysql-connector-j/blob/e0e8e3461e5257ba4aa19e6b3614a2685b298947/src/main/user-impl/java/com/mysql/cj/jdbc/ConnectionImpl.java#L2759-L2780

Also happy to raise a PR to update the MySQL impl to a different recommended class? https://github.com/mysql/mysql-connector-j/blob/release/9.x/src/main/user-impl/java/com/mysql/cj/jdbc/MysqlDataSource.java#L160-L168

https://github.com/brettwooldridge/HikariCP/blob/dev/README.md?plain=1#L484

Or is that not recommended?

Maybe this raises a question about removing that table altogether to remove the maintenance burden.

Love the library, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment