Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty tab slot left behind after deleting Session #3140

Closed
philrz opened this issue Aug 19, 2024 · 1 comment · Fixed by #3143
Closed

Empty tab slot left behind after deleting Session #3140

philrz opened this issue Aug 19, 2024 · 1 comment · Fixed by #3143
Assignees
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Aug 19, 2024

Repro is with Zui commit d3a0402. This was first spotted when testing the #3132 branch but we decided to merge what was there and fix this after.

Repro steps shown in the attached video:

  1. Load some data
  2. Click to the Sessions list in the left panel
  3. Close the pool page for the data just added
  4. Start one Session and run a count() on the pool
  5. Start a second session and run a search (e.g., google) on the pool
  6. Right-click and delete the Session with count() from the list

An empty slot is left behind for the deleted tab. This empty slot is filled in as soon as I click another tab.

Repro.mp4
@philrz philrz added the bug Something isn't working label Aug 19, 2024
@philrz philrz changed the title Empty tab slow left behind after deleting Session Empty tab left behind after deleting Session Aug 19, 2024
@philrz philrz changed the title Empty tab left behind after deleting Session Empty tab slot left behind after deleting Session Aug 19, 2024
@philrz philrz mentioned this issue Sep 7, 2024
5 tasks
@philrz
Copy link
Contributor Author

philrz commented Sep 10, 2024

Verified in Zui commit f6f28ac.

As shown in the attached video, now when I repeat the repro steps, there's no longer an empty tab slot left behind after I delete the Session.

Verify.mp4

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants