-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian release artifact #631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
force-pushed
the
linux-installers
branch
2 times, most recently
from
April 17, 2020 17:16
b92e5f7
to
97059c9
Compare
jameskerr
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great
mikesbrown
reviewed
Apr 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Did you test opening the app and performing a pcap ingest -> get pcap from Brim round trip after you installed on Debian 10 / Gnome 3?
- The copyright file in
/usr/share/doc/brim/copyright
is somebody else's.Copyright (c) 2013-2019 GitHub Inc.
Add install script for linux which currently creates only .deb artifact for debian based linux distributions. Also add github action for creating linux release artifacts.
mattnibs
force-pushed
the
linux-installers
branch
from
April 20, 2020 16:18
622d93b
to
409d32a
Compare
mikesbrown
approved these changes
Apr 20, 2020
alfred-landrum
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐧 🎉
mattnibs
force-pushed
the
linux-installers
branch
from
April 20, 2020 16:38
e606481
to
dd9843e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--linux
option to scripts/release. Currently will generate only debianpackage (future prs will generate packages for rpm and flatpak).
Also add github action for creating linux release artifacts.
New dependency
electron-installer-debian
when imported as a devDependencycaused windows to fail on
npm i
. As a result I had to make it an optionalDependencies.AppIcon appears to be working (debian 10 running gnome 3):
part of #618