Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian release artifact #631

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Debian release artifact #631

merged 5 commits into from
Apr 20, 2020

Conversation

mattnibs
Copy link
Contributor

@mattnibs mattnibs commented Apr 17, 2020

Add --linux option to scripts/release. Currently will generate only debian
package (future prs will generate packages for rpm and flatpak).
Also add github action for creating linux release artifacts.

New dependency electron-installer-debian when imported as a devDependency
caused windows to fail on npm i. As a result I had to make it an optionalDependencies.

AppIcon appears to be working (debian 10 running gnome 3):
image

part of #618

@mattnibs mattnibs force-pushed the linux-installers branch 2 times, most recently from b92e5f7 to 97059c9 Compare April 17, 2020 17:16
@mattnibs mattnibs requested a review from a team April 17, 2020 17:18
Copy link
Member

@jameskerr jameskerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

Copy link
Contributor

@mikesbrown mikesbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Did you test opening the app and performing a pcap ingest -> get pcap from Brim round trip after you installed on Debian 10 / Gnome 3?
  2. The copyright file in /usr/share/doc/brim/copyright is somebody else's.
    Copyright (c) 2013-2019 GitHub Inc.
    

.github/workflows/linux-release.yml Outdated Show resolved Hide resolved
.github/workflows/linux-release.yml Outdated Show resolved Hide resolved
@alfred-landrum
Copy link
Contributor

I was able to build & install the debian package (via dpkg -i brim_amd64.deb) and run it on a Ubuntu 18.04.1 LTS vm, including open a pcap & launching wireshark.
Screen Shot 2020-04-19 at 19 57 45

Add install script for linux which currently creates only .deb artifact
for debian based linux distributions. Also add github action for
creating linux release artifacts.
Copy link
Contributor

@alfred-landrum alfred-landrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐧 🎉

@mattnibs mattnibs merged commit 314f149 into master Apr 20, 2020
@mattnibs mattnibs deleted the linux-installers branch April 20, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants