-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration test for rpm package #684
Conversation
d7888cd
to
30a06ff
Compare
APPVEYOR: true | ||
needs: build | ||
steps: | ||
- run: dnf install -y xorg-x11-server-Xvfb git nss-tools pulseaudio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please file an issue to have us create our own centos8 image that contains this software.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Do we have a repo where these images are created? Are they attached to ci?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we had circleci, a dockerfile was put in the .circleci directory, and the image the dockerfile created was used in CI. So far we only use others' images. I don't believe a separate repository is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er, I was assuming you meant Git repository. We have a brimsec org on docker hub where a built image can be uploaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Integration Tests (Centos 8) | ||
run: | | ||
dnf install -y ./linux-release/brim_x86_64.rpm | ||
xvfb-run -d -s "-screen 0 1280x1024x24" npm run itest -- --ci --forceExit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does xvfb-run -d
do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newer version of xvfb
which centos8 has but ubuntu 18 does not says that --auto-servernum
is deprecated and to use -d
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL. Thanks!
Add the build ci phase to build the linux release artifacts (.deb and at the .rpm) at the end of the job then upload artifacts. Add integration_test_centos which downloads the created rpm package and runs the standard suite of integration tests against it. Also: - Have ubuntu integration tests download and run against the created deb package.
Co-Authored-By: Michael Brown <[email protected]>
Co-Authored-By: Michael Brown <[email protected]>
dac9017
to
fab447a
Compare
Add the build ci phase to build the linux release artifacts (.deb and
at the .rpm) at the end of the job then upload artifacts.
Add integration_test_centos which downloads the created rpm package
and runs the standard suite of integration tests against it.
Also:
deb package.
closes #618