Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration test for rpm package #684

Merged
merged 3 commits into from
Apr 28, 2020
Merged

integration test for rpm package #684

merged 3 commits into from
Apr 28, 2020

Conversation

mattnibs
Copy link
Contributor

@mattnibs mattnibs commented Apr 25, 2020

Add the build ci phase to build the linux release artifacts (.deb and
at the .rpm) at the end of the job then upload artifacts.

Add integration_test_centos which downloads the created rpm package
and runs the standard suite of integration tests against it.

Also:

  • Have ubuntu integration tests download and run against the uploaded
    deb package.

closes #618

@mattnibs mattnibs requested a review from a team April 25, 2020 00:13
@mattnibs mattnibs force-pushed the rpm-integration-test branch 2 times, most recently from d7888cd to 30a06ff Compare April 25, 2020 00:29
@mattnibs mattnibs requested a review from mikesbrown April 25, 2020 00:30
.github/workflows/ci.yml Outdated Show resolved Hide resolved
APPVEYOR: true
needs: build
steps:
- run: dnf install -y xorg-x11-server-Xvfb git nss-tools pulseaudio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue to have us create our own centos8 image that contains this software.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Do we have a repo where these images are created? Are they attached to ci?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we had circleci, a dockerfile was put in the .circleci directory, and the image the dockerfile created was used in CI. So far we only use others' images. I don't believe a separate repository is needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er, I was assuming you meant Git repository. We have a brimsec org on docker hub where a built image can be uploaded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- name: Integration Tests (Centos 8)
run: |
dnf install -y ./linux-release/brim_x86_64.rpm
xvfb-run -d -s "-screen 0 1280x1024x24" npm run itest -- --ci --forceExit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does xvfb-run -d do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newer version of xvfb which centos8 has but ubuntu 18 does not says that --auto-servernum is deprecated and to use -d instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. Thanks!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
mattnibs and others added 3 commits April 28, 2020 09:23
Add the build ci phase to build the linux release artifacts (.deb and
at the .rpm) at the end of the job then upload artifacts.

Add integration_test_centos which downloads the created rpm package
and runs the standard suite of integration tests against it.

Also:
- Have ubuntu integration tests download and run against the created
deb package.
@mattnibs mattnibs force-pushed the rpm-integration-test branch from dac9017 to fab447a Compare April 28, 2020 16:24
@mattnibs mattnibs merged commit 8a4d802 into master Apr 28, 2020
@mattnibs mattnibs deleted the rpm-integration-test branch April 28, 2020 17:09
@mattnibs mattnibs linked an issue May 7, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create base centos8 integration image Initial Linux release
2 participants