Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Cleanup color management #2109

Open
Caellian opened this issue Dec 8, 2024 · 1 comment
Open

[Enhancement]: Cleanup color management #2109

Caellian opened this issue Dec 8, 2024 · 1 comment
Labels
enhancement suggests alteration of existing functionality to better support different use cases

Comments

@Caellian
Copy link
Collaborator

Caellian commented Dec 8, 2024

@bi4k8 mentioned this in #1504 and I agree:

I think we need to decide once and for all how to handle alpha in Conky: is it separate from colors, or included with them? We conflate ends and means in the current configuration scheme: own_window_transparent overrides own_window_argb_value, but should really be equivalent to own_window_argb_value = 0, except that it actually triggers a different implementation that can work in more X11 configurations. Meanwhile, color parsing does support reading alpha values, except for places where the parsed alpha is overridden by xftalpha or own_window_argb_value.

Originally posted by @bi4k8 in #1504 (comment)

This is very confusing to deal with by users. As a user I'd expect a single window_background = "color" property that also accepts alpha, and then for conky to deal with all the implementation details.

There are however 3 different config options for this "1 concept":

  • own_window_argb_value
  • own_window_colour
  • own_window_transparent

And additionally own_window_argb_visual that, when I forget about implementation details of X11, doesn't tell me much.

I suggest the first three to be replaced with simply window_background_colo(u)r, and for the own_window_argb_visual to be renamed to enable_x11_true_transparency because that communicates so much more details at a first glance:

  • I know there's "fake" transparency
  • I know it's only X11
    • because Wayland makes it hard to do the other (worse) thing
  • I know it has (almost) nothing to do with actual "rgb" color value.
@Caellian Caellian changed the title Cleanup color management [Refactor]: Cleanup color management Dec 8, 2024
@Caellian Caellian changed the title [Refactor]: Cleanup color management [Improvement]: Cleanup color management Dec 8, 2024
@Caellian Caellian added the enhancement suggests alteration of existing functionality to better support different use cases label Dec 8, 2024
@Caellian Caellian changed the title [Improvement]: Cleanup color management [Enhancement]: Cleanup color management Dec 8, 2024
@Caellian
Copy link
Collaborator Author

Caellian commented Dec 8, 2024

When implemented, this can't break old configs, so old values should be propagated to new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement suggests alteration of existing functionality to better support different use cases
Projects
None yet
Development

No branches or pull requests

1 participant