Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subset PED step in CleanVcf after merging CleanVcf rewrite #274

Closed
epiercehoffman opened this issue Dec 21, 2021 · 1 comment
Closed

Comments

@epiercehoffman
Copy link
Collaborator

The subset PED step added in #250 (two tasks: GetSampleIdsFromVcf and SubsetPedFile) will become unnecessary after the rewrite of CleanVcf is merged, so it should be removed at that time.

Details:
This task was added because CleanVcf1_20 errors out if there is a) a header line in the PED file or b) extra samples with sex=0 in the PED file that are not in the VCF. The rewrite of CleanVcf appears to circumvent these issues by using the VCF sample IDs as a starting point, so the subset PED step should be unnecessary after those updates are merged. It appears that steps prior to CleanVcf are able to handle the header line in the PED file as users did not encounter errors until CleanVcf1_20.

@epiercehoffman
Copy link
Collaborator Author

Addressed in #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant