Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parameter to Control New Browser Window Creation in Render Function #12

Open
4 tasks
bshifaw opened this issue Jun 20, 2024 · 0 comments
Open
4 tasks

Comments

@bshifaw
Copy link

bshifaw commented Jun 20, 2024

Problem:

Currently, the render function in genomeshader/view.py always includes the code to open a new browser window. This behavior is not always desired, and there should be a way to control whether or not this code is included.

Proposed Solution:

Add a boolean parameter to the render function that determines whether or not to include the new browser window code. If the parameter is True, the function should include the code to open a new browser window. If the parameter is False, the function should not include this code.


Tasks:

  • Update the render function signature to include a new boolean parameter, new_window.
  • Update the render function body to conditionally include the new browser window code based on the value of new_window.
  • Update all calls to the render function to include the new new_window parameter.
  • Test the updated render function with new_window set to both True and False to ensure it works as expected.

Acceptance Criteria:

  • The render function should have a new boolean parameter, new_window.
  • If new_window is True, the render function should include the code to open a new browser window.
  • If new_window is False, the render function should not include the code to open a new browser window.
  • All calls to the render function should include the new new_window parameter.
  • The updated render function should be covered by tests to ensure it works as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant