Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sift tool must be updated to work for arbitrary models / libraries #150

Open
jonn-smith opened this issue Aug 22, 2022 · 0 comments
Open
Labels
enhancement New feature or request High Priority

Comments

@jonn-smith
Copy link
Collaborator

jonn-smith commented Aug 22, 2022

Currently sift only works for mas_15_sc_10x5p_single_none.

We must expand this tool to work for any input library by removing the "validation model" (10x_sc_10x5p_single_none) and deriving a custom validation model at runtime for the input model.

In addition, we must address the following:

  • sift should be updated to include information about MAS adapters, rather than relying on random segments at the start of each array element
  • model::validate_model must be updated to remove the "skip" for the validation model. Validation models should be valid models, or the logic must be updated to somehow validate them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High Priority
Projects
None yet
Development

No branches or pull requests

1 participant