Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New segment cigars need to be refactored #177

Open
jonn-smith opened this issue Nov 3, 2022 · 0 comments
Open

New segment cigars need to be refactored #177

jonn-smith opened this issue Nov 3, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@jonn-smith
Copy link
Collaborator

jonn-smith commented Nov 3, 2022 •
edited
Loading

The new cigars that are produced by the model for each segment need to be updated in 2 ways:

  1. The cigar operator and count are currently in the wrong order. The proper order is: <count><op>
  2. The cigar operators are the states in the HMM. They should be changed to reflect the real cigar operators, including = and X.

This will disproportionately effect inspect, but will also have ramifications in other tools.
@jonn-smith jonn-smith added the bug Something isn't working label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonn-smith