Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: unknown type: "TSNamedTupleMember" #548

Closed
adalinesimonian opened this issue May 21, 2021 · 2 comments
Closed

Error: unknown type: "TSNamedTupleMember" #548

adalinesimonian opened this issue May 21, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@adalinesimonian
Copy link
Contributor

prettierx errors out when linting typescript files with named tuples.

This bug was ironed out in prettier/prettier#8885 last August. However, this bug fix, along with others, has not yet been merged into prettierx. prettier is currently at version 2.3.0, released 12 days ago at the time of this post, and this particular fix was merged just before the release of 2.1.0 in August.

Related to #414
@adalinesimonian
Copy link
Contributor Author

Opened draft PR in #549, working on merging prettier 2.3.0 into prettierx, which includes fixes for typescript

@adalinesimonian adalinesimonian mentioned this issue May 23, 2021
Closed
8 tasks
@brody4hire brody4hire added the bug Something isn't working label May 24, 2021
@brody4hire brody4hire mentioned this issue May 24, 2021
Closed
@adalinesimonian adalinesimonian mentioned this issue Jun 7, 2021
Closed
8 tasks
@adalinesimonian adalinesimonian mentioned this issue Jun 17, 2021
Closed
@brody4hire
Copy link
Owner

This should be resolved now that we have merged the updates from Prettier 2.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@brody4hire @adalinesimonian