forked from prettier/prettier
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prettierx] --no-align-ternary-lines option #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to resolve conflict with standard resolves prettier#40 Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Mohit Singh <[email protected]> Co-authored-by: Ika <[email protected]>
brody4hire
referenced
this pull request
Jan 22, 2019
in tests/standard & docs as reported in brody4hire/prettierx#40 (this should have been part of the proposal in prettier#5723) Note that this inconsistency is resolved by brody4hire/prettierx#41 which is to be included in an upcoming merge. Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Mohit Singh <[email protected]> Co-authored-by: Adam Stankiewicz <[email protected]>
brody4hire
referenced
this pull request
Jan 22, 2019
in tests/standard & docs as reported in brody4hire/prettierx#40 (this should have been part of the proposal in prettier#5723) Note that this inconsistency is resolved by brody4hire/prettierx#41 which is to be included in an upcoming merge. Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Mohit Singh <[email protected]> Co-authored-by: Adam Stankiewicz <[email protected]>
with strikeout of issue that is resolved in this branch
Co-authored-by: CJB <[email protected]> Co-authored-by: Ika <[email protected]> Co-authored-by: Lucas Azzola <[email protected]>
brody4hire
referenced
this pull request
Jan 22, 2019
- Add note that it is desired to provide the additional formatting options in a prettier plugin as discussed in brody4hire/prettierx#37 - Add phrase that brody4hire/prettierx#40 is resolved by brody4hire/prettierx#41 which is to be included by an upcoming merge.
brody4hire
changed the title
[prettierx] --no-align-ternary-lines option - WIP with TODO items
[prettierx] --no-align-ternary-lines option
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to resolve a conflict with
standard
as reported in brody4hire/prettierx#40with test updates in:
tests/standard
tests/ternaries