Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prettierx] --no-align-ternary-lines option #41

Merged
merged 12 commits into from
Jan 22, 2019

Conversation

brody4hire
Copy link
Collaborator

@brody4hire brody4hire commented Jan 22, 2019

to resolve a conflict with standard as reported in brody4hire/prettierx#40

with test updates in:

  • tests/standard
  • tests/ternaries

Christopher J. Brody and others added 3 commits January 21, 2019 17:57
to resolve conflict with standard

resolves prettier#40

Co-authored-by: Christopher J. Brody <[email protected]>
Co-authored-by: Mohit Singh <[email protected]>
Co-authored-by: Ika <[email protected]>
@brody4hire brody4hire changed the base branch from dev to master January 22, 2019 16:03
brody4hire referenced this pull request Jan 22, 2019
in tests/standard & docs

as reported in brody4hire/prettierx#40

(this should have been part of the proposal in prettier#5723)

Note that this inconsistency is resolved by brody4hire/prettierx#41
which is to be included in an upcoming merge.

Co-authored-by: Christopher J. Brody <[email protected]>
Co-authored-by: Mohit Singh <[email protected]>
Co-authored-by: Adam Stankiewicz <[email protected]>
brody4hire referenced this pull request Jan 22, 2019
in tests/standard & docs

as reported in brody4hire/prettierx#40

(this should have been part of the proposal in prettier#5723)

Note that this inconsistency is resolved by brody4hire/prettierx#41
which is to be included in an upcoming merge.

Co-authored-by: Christopher J. Brody <[email protected]>
Co-authored-by: Mohit Singh <[email protected]>
Co-authored-by: Adam Stankiewicz <[email protected]>
brody4hire referenced this pull request Jan 22, 2019
- Add note that it is desired to provide the additional formatting
  options in a prettier plugin as discussed in brody4hire/prettierx#37

- Add phrase that brody4hire/prettierx#40 is resolved by
  brody4hire/prettierx#41 which is to be included by an upcoming merge.
@brody4hire brody4hire changed the title [prettierx] --no-align-ternary-lines option - WIP with TODO items [prettierx] --no-align-ternary-lines option Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant