-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix alignTernaryLines behavior #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aMarCruz I would like to first thank you on behalf of the entire user community for this contribution.
I will probably need a few days for a more careful review.
As I said in the line comments, it would be great if you could explain the motivation for each of the two lines you added to tests/standard/jsfmt.spec.js
, One of the added lines is already merged in from PR #47 and should be removed from this proposal (by merge or rebase). I would favor moving the other one to its own PR as well.
tests/standard/jsfmt.spec.js
Outdated
@@ -1,4 +1,6 @@ | |||
run_spec(__dirname, ["babel", "flow", "typescript"], { | |||
arrowParens: "always", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aMarCruz can you explain the motivation for proposing this change?
I would probably favor making this change in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ups, I thought that setting was from Standard, but it is from my own config.
tests/standard/jsfmt.spec.js
Outdated
@@ -1,4 +1,6 @@ | |||
run_spec(__dirname, ["babel", "flow", "typescript"], { | |||
arrowParens: "always", | |||
endOfLine: "lf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is now merged in from PR #47, should be removed from this proposal by merge or rebase.
Thanks @aMarCruz for the awesome work, it is now merged. I will try to release it soon. |
@brodybits , thanks! As a side note, when using This style is not so pretty but it avoids conflicts and is quite consistent. |
Thanks @aMarCruz for the side note. Should we consider documenting this, or maybe just adding a comment somewhere? |
@brodybits, sure. But I don't know where and my "english" is poor. Anyway, in the wiki of eslint-plugin-prettierx I will explain details about the behavior. I hope to have a usable version in one or two days, ...right now I'm $tarting a new project :) |
See prettier#44
docs/
directory)CHANGELOG.unreleased.md
file following the template.✨Try the playground for this PR✨