-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Python 3.8+ and Django 3.2+ #28
Conversation
dd0dbd3
to
48fa079
Compare
I've updated my PR with the fewest changes to support Django 3.2+ and Python 3.7+ I will leave any other non-essential change proposals (eg: black, precommit, ...) after the merge of this PR to speed up the release of version 2.0 which is necessary to migrate the djangoproject.com site to Django > 3.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pauloxnet 👋🏼
Great work here! Looks good overall (I just have one minor question which is mentioned inline).
I think we can request the maintainer to review/merge and make a release on PyPI then.
Hi Folks, Thanks for the great work, and sorry for not being very active over here. Would it be OK for me to transfer this repository to https://github.com/django? As well as the PyPI rights… I don't have a lot of interest in maintaining this project anymore, and it seems it's holding you back. Let me know what you think, thanks! |
Hi @brutasse That is a great idea. Maybe @carltongibson / @felixxm can help with the ownership transfer. If taking this project inside the Django organization isn't feasible, we're also happy to take care of it without the ownership transfer. We'll need push access to this repo and PyPI. |
Hi @brutasse and thank you for your message. I would suggest that you consider moving the package to https://github.com/jazzband , it's a switch that many packages that are used in the Django ecosystem have made. If you think this might work for you here you will find a guide ready with the steps to do and if you want I'm available to help you Could I still ask you to take a look at the open PR and if you deem it appropriate, merge it? This would allow us to generate a new version on PyPI right away, for use in djangoproject.com, while simultaneously turning on the ownership transfer. |
I agree with @pauloxnet, moving to @jazzband is a better idea. |
Hi @brutasse (sorry for the ping) hope you're well 👋 I guess will have to move the contributing section from the readme to a contributing file (with some jazzband lines on top) but the project seems very suitable so I think should be quite straight forward 🙂 |
Hi @sarahboyce and no worries, @pauloxnet and @CuriousLearner should have the necessary permissions to merge this PR. I'm happy to grant all ownership and permissions (gh, pypi) to whoever is willing to move this project forward. I fully support the idea of finding a better home for this project, however I'm not at a point where I can do the jazzband transfer myself so any help is much appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Bruno ❤️
Alright @pauloxnet merge away, this looks great to me! ⭐
I can work on a PR for the contributing guide today but also tell me if there's anything I can do to support 👍
@sarahboyce this PR is one year old, I'll review it today and eventually, I update it and then ask for a review from you. |
af6a1e2
to
07c526b
Compare
de61549
to
594d867
Compare
594d867
to
2b7b645
Compare
2b7b645
to
c983093
Compare
@sarahboyce @CuriousLearner Since the pipelines on Travis no longer work I added the Github workflows to run tests in all versions. I would ask you for further review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
Fix #29