Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python 3.8+ and Django 3.2+ #28

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

pauloxnet
Copy link
Collaborator

@pauloxnet pauloxnet commented Dec 3, 2022

Fix #29

@pauloxnet pauloxnet marked this pull request as ready for review December 3, 2022 21:31
@pauloxnet
Copy link
Collaborator Author

I've updated my PR with the fewest changes to support Django 3.2+ and Python 3.7+

I will leave any other non-essential change proposals (eg: black, precommit, ...) after the merge of this PR to speed up the release of version 2.0 which is necessary to migrate the djangoproject.com site to Django > 3.2.

@pauloxnet pauloxnet changed the title Update to Python 3.7+ Django 3.2 Update to Python 3.7+ Django 3.2+ Feb 22, 2023
Copy link
Collaborator

@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pauloxnet 👋🏼

Great work here! Looks good overall (I just have one minor question which is mentioned inline).

I think we can request the maintainer to review/merge and make a release on PyPI then.

@brutasse
Copy link
Owner

Hi Folks,

Thanks for the great work, and sorry for not being very active over here.

Would it be OK for me to transfer this repository to https://github.com/django? As well as the PyPI rights… I don't have a lot of interest in maintaining this project anymore, and it seems it's holding you back.

Let me know what you think, thanks!

@CuriousLearner
Copy link
Collaborator

CuriousLearner commented Mar 29, 2023

Hi @brutasse

That is a great idea. Maybe @carltongibson / @felixxm can help with the ownership transfer.

If taking this project inside the Django organization isn't feasible, we're also happy to take care of it without the ownership transfer. We'll need push access to this repo and PyPI.

@pauloxnet
Copy link
Collaborator Author

Would it be OK for me to transfer this repository to https://github.com/django? As well as the PyPI rights… I don't have a lot of interest in maintaining this project anymore, and it seems it's holding you back.

Let me know what you think, thanks!

Hi @brutasse and thank you for your message.

I would suggest that you consider moving the package to https://github.com/jazzband , it's a switch that many packages that are used in the Django ecosystem have made.

If you think this might work for you here you will find a guide ready with the steps to do and if you want I'm available to help you
https://jazzband.co/about/guidelines

Could I still ask you to take a look at the open PR and if you deem it appropriate, merge it?

This would allow us to generate a new version on PyPI right away, for use in djangoproject.com, while simultaneously turning on the ownership transfer.

@felixxm
Copy link

felixxm commented Mar 29, 2023

I agree with @pauloxnet, moving to @jazzband is a better idea.

@sarahboyce
Copy link

Hi @brutasse (sorry for the ping) hope you're well 👋
How do you feel about @pauloxnet's suggestion of merging this PR and then moving this to @jazzband?

I guess will have to move the contributing section from the readme to a contributing file (with some jazzband lines on top) but the project seems very suitable so I think should be quite straight forward 🙂

@brutasse
Copy link
Owner

Hi @sarahboyce and no worries,

@pauloxnet and @CuriousLearner should have the necessary permissions to merge this PR. I'm happy to grant all ownership and permissions (gh, pypi) to whoever is willing to move this project forward. I fully support the idea of finding a better home for this project, however I'm not at a point where I can do the jazzband transfer myself so any help is much appreciated.

Copy link

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Bruno ❤️

Alright @pauloxnet merge away, this looks great to me! ⭐
I can work on a PR for the contributing guide today but also tell me if there's anything I can do to support 👍

@pauloxnet
Copy link
Collaborator Author

Alright @pauloxnet merge away, this looks great to me! ⭐ I can work on a PR for the contributing guide today but also tell me if there's anything I can do to support 👍

@sarahboyce this PR is one year old, I'll review it today and eventually, I update it and then ask for a review from you.

.travis.yml Outdated Show resolved Hide resolved
@pauloxnet pauloxnet marked this pull request as draft November 30, 2023 18:51
@pauloxnet pauloxnet force-pushed the feature/python37+django32 branch 2 times, most recently from af6a1e2 to 07c526b Compare November 30, 2023 18:57
@pauloxnet pauloxnet marked this pull request as ready for review November 30, 2023 19:25
@pauloxnet pauloxnet force-pushed the feature/python37+django32 branch 3 times, most recently from de61549 to 594d867 Compare November 30, 2023 19:49
@pauloxnet pauloxnet changed the title Update to Python 3.7+ Django 3.2+ Update to Python 3.8+ and Django 3.2+ Nov 30, 2023
@pauloxnet
Copy link
Collaborator Author

@sarahboyce @CuriousLearner Since the pipelines on Travis no longer work I added the Github workflows to run tests in all versions.
You can see the results here:
https://github.com/pauloxnet/django-push/actions/runs/7051709347

I would ask you for further review

Copy link

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahboyce sarahboyce mentioned this pull request Dec 1, 2023
6 tasks
@pauloxnet pauloxnet merged commit 22fda99 into brutasse:master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django 3.2+ support
5 participants