-
Notifications
You must be signed in to change notification settings - Fork 41
[BUG] WooCommerce Admin Plugin blocks IPN calls to BTCPay for Woo #28
Comments
@pavlenex do you have more logs? |
What is the order id saved in btcpay? |
@NicolasDorier The logs that I have from BTCPay plugin. They're the same
Then a bit more
It gives non-existing error
Because our order ID is not alternative numbereing at all, it's default WooCommerce numbering. With debug enabled
|
@pavlenex I mean, beside the exception, you should have information logs. Here you are only pasting the exception, not the log happening before it crashes. |
After going back and forth with @NicolasDorier it's definetelly an issue with the Woo Admin plugin, as soon as it's disabled order statuses and IPN calls get bumped and work correctly. |
I think this fixes the issue: #30 |
Sorry, you are right, something's off still, I was trying without logging in. When I am logged in, it does not work even without WooCommerce Admin. I have this in my log: Receiving IPN for an order which has no expected invoice ID, ignoring the IPN |
Invoice event logs in BTCPay
Logs for invoice #758 in Woo
|
You are right, I was testing just with the commit. I think the culprit here is this: The latest version that I was testing was 3.0.6 that was in WordPress plugin directory, it switched to 3.0.8 and I think this code was not in 3.0.6 that was in the plugin directory. |
@jooray but how can this code be wrong? |
Also this code works locally. I have the feeling this error has nothing to with the issue. |
This error can happen during the invoice_created event, which is OK. But if somebody pays, it should not. |
no it does not work for me actually FUCK PHP. I revert my code. |
actually FUCK boolean logic. |
I sent a pull request. |
you don't need to revert it. But please make 3.0.9, because if someone's PHP automatically updated, they got introduced this bug, because 3.0.7 (with the bug) was not in the plugin directory. |
@pavlenex good catch! |
I pushed 3.0.9 |
Version 3.0.7 was around for long but I actually did not built it correctly and it was 3.0.6 under the hood, that's why the error did not show up before... |
Thanks for quickly fixing it guys, tested with 3.0.9 and it works even with Woo Admin, so I'll close this issue. Thanks for your contributions @jooray feel free to drop by on our chat.btcpayserver.org on Mattermost to discuss future development and philosophy :P |
Hi. It looks like this issue is back. WooCommerce Admin v 0.21.0 When i activate WooCommerce Admin i got php error in logs during payment, also status of the order haven’t changed. Deactivate WooCommerce Admin and everything works. PHP logs:
|
Can you try on 3.0.10? |
Hi there, same problem here in last versions of WP, WooCommerce and BTCPay:
|
Recently, WooCommerce started asking people to optionally install WooCommerce Admin plugin. When this plugin is active it blocks IPN calls to BTCPay for Woo, so order statuses are not updated and as a result, BTCPay invoice on the server side gives Unexpected return code: 500.
While this is not related to #23 entirely, people on that issue were able to reproduce this bug and so did I.
Invoice Events
So the conflict blocks the IPN calls from BTCPay to WooCommerce and the order status in Woo does not change when the WooCommerce Admin plugin is active.
The text was updated successfully, but these errors were encountered: