Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about Gaussian Semantic Tracing implementation. #64

Open
broiron opened this issue Sep 5, 2024 · 0 comments
Open

Question about Gaussian Semantic Tracing implementation. #64

broiron opened this issue Sep 5, 2024 · 0 comments

Comments

@broiron
Copy link

broiron commented Sep 5, 2024

Hello, Thanks for your work!

While analyzing the paper and code together, there was something curious about Semantic Tracing

In the paper, the following equation is used to calculate the weight of i-th Gaussian:
$w_i = \sum o_i(p) * T_i(p) * M(p) $

However, in the code, particularly in apply_weight.cu, which seems to be the part assigning weight to the Gaussian, it appears to be implemented differently from the equation above.

// apply_weights.cu renderCUDA_apply_weights
for (int ch=0; ch<CHANNELS; ch++) {
    atomicAdd(weights + (collected_id[j] * CHANNELS + ch), C[ch]);
    atomicAdd(cnt + collected_id[j], 1);
}
...

When the Gaussian is used to render a 2D masked region, it seems the weight is calculated by just adding the mask value (0 or 1), which is C[ch]. And the average weight is calculated by dividing it in cnt.

Is that correct? Because It seems that the weight calculation method doesn't follow the equation in the paper, so I'm reaching out to inquire.

I would appreciate any insights from those who are familiar with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant