Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: goal event not being acknowledged correctly #159

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Conversation

cre8ivejp
Copy link
Member

@cre8ivejp cre8ivejp commented Jan 16, 2023

Because the calculator service already adds a buffer of 48 hours before stopping the running experiments, there is no need to validate the timestamp. Also, there is no need to list stopped experiments.

  • Changed to list only running experiments
  • Removed timestamp validation

@cre8ivejp cre8ivejp requested a review from masaaania January 16, 2023 06:19
masaaania
masaaania previously approved these changes Jan 16, 2023
Copy link
Contributor

@masaaania masaaania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me 👍

@cre8ivejp
Copy link
Member Author

@masaaania
I checked the condition to list the experiments in the calculator service, and it doesn't see the archive flag, so I removed it from the event persister to avoid future issues.

req = experiment_service_pb2.ListExperimentsRequest(
environment_namespace=environment_namespace,
statuses=[
experiment_pb2.Experiment.WAITING,
experiment_pb2.Experiment.RUNNING,
],
page_size=_PAGE_SIZE,
cursor=cursor,
)

@masaaania masaaania self-requested a review January 16, 2023 06:54
Copy link
Contributor

@masaaania masaaania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you 👍

@cre8ivejp cre8ivejp merged commit 38b9bd0 into main Jan 16, 2023
@cre8ivejp cre8ivejp deleted the fix-event-persister branch January 16, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants