fix: mysql error alerts when the auto ops rule is already triggered #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre8ivejp
commented
Jan 27, 2023
| @@ -836,6 +833,13 @@ func (s *AutoOpsService) ExecuteAutoOps( | |||
| if err := s.validateExecuteAutoOpsRequest(req, localizer); err != nil { | |||
| return nil, err | |||
| } | |||
| triggered, err := s.checkIfHasAlreadyTriggered(ctx, localizer, req.Id, req.EnvironmentNamespace) | |||
There was a problem hiding this comment.
I had to move this implementation from the transaction to check if it had already been triggered because the response returns the AlreadyTriggered boolean.
| handler := command.NewAutoOpsCommandHandler(editor, autoOpsRule, s.publisher, req.EnvironmentNamespace) | ||
| if err := handler.Handle(ctx, req.ChangeAutoOpsRuleTriggeredAtCommand); err != nil { | ||
| return err | ||
| } | ||
| if err = autoOpsRuleStorage.UpdateAutoOpsRule(ctx, autoOpsRule, req.EnvironmentNamespace); err != nil { | ||
| if err == v2as.ErrAutoOpsRuleUnexpectedAffectedRows { |
There was a problem hiding this comment.
If there are no affected rows, it will not treat as an error. Otherwise, it might trigger the alert.
| logger.Warn( | ||
| "Failed to disable feature", | ||
| if err != nil { | ||
| if code := status.Code(err); code == codes.FailedPrecondition { |
There was a problem hiding this comment.
I split the implementation to print warning and error levels to make debugging easier.
cre8ivejp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user schedule to turn on a flag, and before the auto ops run, he enables the flag, it will treat it as an error, so I'm changing the ExecuteOperation to return nil if the operation is already done.
Things done