feat(ui): show which flag the segment user is using when deleting or updating it #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bimalgrg519, please close and delete the branch if you don't need this PR. |
cre8ivejp
changed the title
bimalgrg519
force-pushed
the
user-segments-users-id
branch
3 times, most recently
from
ac34152 to
8050f5d
Compare
cre8ivejp
reviewed
Jun 20, 2023
| }), | ||
| cannotDelete: defineMessage({ | ||
| id: 'segment.confirm.delete.cannotDelete', | ||
| defaultMessage: | ||
| 'The 「{segmentName}」 segment is being used, and you cannot delete it.', | ||
| "This {segmentName} segment can't be deleted because {length} {length, plural, one {flag is} other {flags are}} using it.", |
bimalgrg519
force-pushed
the
user-segments-users-id
branch
from
8050f5d to
be6a2bf
Compare
bimalgrg519
force-pushed
the
user-segments-users-id
branch
from
be6a2bf to
e2e70aa
Compare
cre8ivejp
reviewed
Jun 25, 2023
| @@ -415,6 +415,8 @@ | |||
| "segment.update.header.description": "ユーザーセグメントを使用すると、単一のフィーチャーフラグバリエーションのすべてのユーザーターゲットを管理できます。これを使用して、多数のユーザーターゲットに対して一度に変更を加えることができます。例えば、既存のベータユーザー群に対して、機能をテスト可能になります。", | |||
| "segment.update.header.title": "ユーザーセグメントの更新", | |||
| "segment.update.userId": "ユーザーID一覧は他の{length}件のフラグに使用中のため、更新できません。このセグメントをフラグから削除してから更新してください。", | |||
| "segment.uploading.message": "ユーザー一覧のアップロードが完了するまでセグメントの更新はできません。", | |||
There was a problem hiding this comment.
@bimalgrg519, please update this message as follows.
ユーザー一覧はアップロード中のため、セグメントユーザーの更新ができません。
Ubisoft-potato
pushed a commit
to Ubisoft-potato/bucketeer
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #276