fix: change GetEvaluations request field #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaaania
force-pushed
the
get_evaluations
branch
from
34cab84 to
afcd6e5
Compare
masaaania
commented
Jul 12, 2023
Comment on lines
-38
to
+42
| int64 evaluated_at = 6; | ||
| bool user_attributes_updated = 7; | ||
| UserEvaluationCondition user_evaluation_condition = 6; |
There was a problem hiding this comment.
Any SDK does not use the evaluated_at and user_attributes_updated.
|
@cre8ivejp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user_evaluation_conditionfield to GetEvaluationsRequest to determine which evaluation method should be used.user_evaluation_conditionfield is not set to any value, Bucketeer evaluates the flags with the old evaluation method.